Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chains image env for openshift #659

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Mar 7, 2022

This will add the env in config.yaml for generating csv
on OpenShift so that the redhat build image can refelect
in csv and replaced during installation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

This will add the env in config.yaml for generating csv
on OpenShift so that the redhat build image can refelect
in csv and replaced during installation
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 7, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2022
Copy link
Contributor

@concaf concaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-garg
Copy link
Contributor Author

piyush-garg commented Mar 7, 2022

Do we also need to add the env here? https://github.com/tektoncd/operator/blob/main/operatorhub/openshift/release-artifacts/bundle/manifests/openshift-pipelines-operator-rh.clusterserviceversion.yaml

This is the generated one using config, we don't need to add here afaik. cc @nikhil-thomas

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@nikhil-thomas
Copy link
Member

This is the generated one using config, we don't need to add here afaik. cc @nikhil-thomas

yes that is right.

However, if you want you can generate the csv and push wiht this pr. So that it will serve as a reference. Also it will be a check.

@concaf
Copy link
Contributor

concaf commented Mar 7, 2022

@nikhil-thomas thanks, so let's let it get auto-generated!?
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@PuneetPunamiya
Copy link
Member

/retest

@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot merged commit 9ca520e into tektoncd:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants