Mount CA bundles in Tekton components as well #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following is the coverage report on the affected files.
|
3640c35 to
76b1431
Compare
|
The following is the coverage report on the affected files.
|
76b1431 to
8a95b19
Compare
|
The following is the coverage report on the affected files.
|
|
/retest |
8a95b19 to
be51c09
Compare
|
The following is the coverage report on the affected files.
|
be51c09 to
0fef2a0
Compare
Prior to this commit, the CA bundles were: - mounted inside containers - exposed via VolumeMounts and SSL_CERT_DIR only in TaskRun pods via `pkg/reconciler/proxy/proxy.go` but were not exposed in Tekton components controllers like pipelines, triggers and chains via `pkg/reconciler/openshift/common/cabundle.go`. This meant that these Tekton components could not talk to internal OpenShift services or to hosts for which users added certificates to the cluster via CA bundles. One case where this is a problem is when the Chains controller wants to pull images from the internal OpenShift registry to sign and then push the signatures, attestations back to it since it does not have access to the Service CA Bundle. This commit abstracts away the exposure of certificates via Volumes, VolumeMounts and SSL_CERT_DIR in `pkg/reconciler/common/certificates.go` and makes this behavior the same for both TaskRuns and controllers which want to mount these certificates.
0fef2a0 to
d538041
Compare
|
The following is the coverage report on the affected files.
|
|
LGTM :) |
vdemeester
approved these changes
Mar 4, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this commit, the CA bundles were:
only in TaskRun pods via
pkg/reconciler/proxy/proxy.gobut were notexposed in Tekton components controllers like pipelines, triggers and
chains via
pkg/reconciler/openshift/common/cabundle.go.This meant that these Tekton components could not talk to internal
OpenShift services or to hosts for which users added certificates to the
cluster via CA bundles.
One case where this is a problem is when the Chains controller wants to
pull images from the internal OpenShift registry to sign and then push
the signatures, attestations back to it since it does not have access to
the Service CA Bundle.
This commit abstracts away the exposure of certificates via Volumes,
VolumeMounts and SSL_CERT_DIR in
pkg/reconciler/common/certificates.goand makes this behavior the same for both TaskRuns and controllers which
want to mount these certificates.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.