Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a webhook definition service namespace transform #637

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add a webhook definition service namespace transform #637

merged 1 commit into from
Mar 2, 2022

Conversation

nikhil-thomas
Copy link
Member

@nikhil-thomas nikhil-thomas commented Mar 1, 2022 •
edited
Loading

Add a transformation to mutating/validating webhook definitions to
ensure that the webhook pod namespace is set as the service namespace
in webhook definition.

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fixes operator webhooks failing to find webhook service when operator is installed in a namespace other than tektoncd-operator (openshift-operators)

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 1, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/webhook/webhook_init.go Do not exist 13.0%

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@nikhil-thomas nikhil-thomas force-pushed the fix/webhook-service-namespace branch from 857ad46 to 0cd19aa Compare March 1, 2022 09:43
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/webhook/webhook_init.go Do not exist 13.0%

@nikhil-thomas
Add a webhook definition service namespace transform
9154211 
Add a transformation to mutating/validating webhook definitions to
ensure that the webhook pod namespace is set as the service namespace
in webhook definition.

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@nikhil-thomas nikhil-thomas force-pushed the fix/webhook-service-namespace branch from 0cd19aa to 9154211 Compare March 1, 2022 12:22
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/webhook/webhook_init.go Do not exist 13.0%

@nikhil-thomas
Copy link
Member Author

/retest

@sm43
Copy link
Member

sm43 commented Mar 2, 2022

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@sm43: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@tekton-robot tekton-robot merged commit 447d5ba into tektoncd:main Mar 2, 2022
@vdemeester vdemeester mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@sm43 sm43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhil-thomas @tekton-robot @sm43 @vdemeester