Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Hub Db deployment in case of Openshift #636

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Updates Hub Db deployment in case of Openshift #636

merged 1 commit into from
Mar 4, 2022

Conversation

PuneetPunamiya
Copy link
Member

@PuneetPunamiya PuneetPunamiya commented Feb 28, 2022 •
edited
Loading

Changes

  • This patch adds a transformer which updates the db deployment,
    in case of openshift to use productized postgres images and also
    replace a few env and commands for readiness and liveness probes

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 28, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 28, 2022
@PuneetPunamiya PuneetPunamiya changed the title Update db deployment in case Updates Hub Db deployment in case of Openshift Feb 28, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go Do not exist 83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go Do not exist 39.3%
pkg/apis/operator/v1alpha1/tektonhub_types.go 100.0% 33.3% -66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go 100.0% 96.2% -3.8
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go 76.3% 77.2% 0.9

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go Do not exist 83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go Do not exist 39.3%
pkg/apis/operator/v1alpha1/tektonhub_types.go 100.0% 33.3% -66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go 100.0% 96.2% -3.8
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go 76.3% 77.2% 0.9
pkg/reconciler/openshift/tektonhub/controller.go Do not exist 0.0%
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.5%

vdemeester
vdemeester approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
We need the two dependent PR to get in before this one, but LGTM

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go Do not exist 83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go Do not exist 39.3%
pkg/apis/operator/v1alpha1/tektonhub_types.go 100.0% 33.3% -66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go 100.0% 96.2% -3.8
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go 76.3% 77.2% 0.9
pkg/reconciler/openshift/tektonhub/controller.go Do not exist 0.0%
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.5%

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 2, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go 39.1% 39.3% 0.2
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.5%

@nikhil-thomas
Copy link
Member

@PuneetPunamiya @piyush-garg should the route creation for ui be handled in the post-reconcile instead of pre-reconcile.

@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 3, 2022 •
edited
Loading

@PuneetPunamiya @piyush-garg should the route creation for ui be handled in the post-reconcile instead of pre-reconcile.

@nikhil-thomas The reason we are creating the the ui route in the pre-reconciler is because the config map of ui will require the ui route,

For this one option could be

  • We create the route in manageUiComponent function before creating the configMap for ui

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go 39.1% 39.3% 0.2
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.0%

@PuneetPunamiya
Updates Hub DB deployment in case of openshift
9ee40b5 
This patch adds a transformer which updates the db deployment,
in case of openshift to use productized postgres images and also
replace a few env and commands for readiness and liveness probes

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonhub/extension.go Do not exist 24.0%

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-operator-integration-tests

@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2022
@tekton-robot tekton-robot merged commit ebfba95 into tektoncd:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm43 sm43 sm43 left review comments

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@nikhil-thomas nikhil-thomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PuneetPunamiya @tekton-robot @nikhil-thomas @vdemeester @sm43