Fix TektonPipeline Ready check #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the availability (creation) of an TektonInstallerSet for TektonPipeline is considered to be the Ready condition for TektonPipeline. This is because the 'ready check' checks the condition item [0] and that item correspond to 'InstallerSet' available. The correct check should depend on condition `Ready` which is set to True when all other conditions are True. This patch ensures that the TektonPipeline Ready check checks the true 'Ready' condition. Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
ab40f78 to
bae91e1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the availability (creation) of an TektonInstallerSet for
TektonPipeline is considered to be the Ready condition for
TektonPipeline.
This is because the 'ready check' checks the condition
item [0] and that item correspond to 'InstallerSet' available.
The correct check should depend on condition
Readywhich is set to Truewhen all other conditions are True.
This patch ensures that the TektonPipeline Ready check checks the true
'Ready' condition.
Example, status.conditions[]
[{InstallerSetAvailable True {2022-02-02 08:47:06 +0000 UTC} } {InstallerSetReady False {2022-02-02 08:47:15 +0000 UTC} Error Installer set not ready: Install failed with message: roles.rbac.authorization.k8s.io "tekton-pipelines-controller" is forbidden: unable to create new content in namespace openshift-pipelines because it is being terminated} {PostReconciler True {2022-02-02 08:47:07 +0000 UTC} } {PreReconciler True {2022-02-02 08:47:06 +0000 UTC} } {Ready False {2022-02-02 08:47:15 +0000 UTC} Error Installer set not ready: Install failed with message: roles.rbac.authorization.k8s.io "tekton-pipelines-controller" is forbidden: unable to create new content in namespace openshift-pipelines because it is being terminated}]ie, status.conditions[0] is
InstallerSetAvailablethe "true" Ready is the itemReadySigned-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes