[release-v0.74.x] Switch to golangci-lint GH action #2506
Closed
+41
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start using the golangci-lint github action and stop using the check as part of the build jobs. This way the version of the actions can be maintained by dependabot, the version of golangci-lint can be updated in the YAML and code in PRs can be annotated with issues. It also reduces the load in the prow job slighlty, saving a little infra cost. Removing the failing golang lint surfaced some issues in the yamllint. Issues in workflow YAMLs have been fixed. All testdata YAML files have been excluded from linting. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
4 tasks
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dependabot rebase |
|
@tekton-robot rebase |
|
/close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2493
/assign jkhelil