Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serviceaccount path #2497

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Fix serviceaccount path #2497

merged 2 commits into from
Jan 11, 2025

Conversation

afrittoli
Copy link
Member

Changes

Final fixes: working build based on this PR

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@afrittoli
Fix serviceAccountImagesPath in release pipeline
502d543 
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli
Some more fixes to the release
3b25e75 
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 10, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
@afrittoli
Copy link
Member Author

@tektoncd/operator-maintainers the last bit to get the build working 🙏

@jkhelil
Copy link
Member

jkhelil commented Jan 11, 2025

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2025
@jkhelil
Copy link
Member

jkhelil commented Jan 11, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2025
@tekton-robot tekton-robot merged commit 44c2eba into tektoncd:main Jan 11, 2025
9 checks passed
@jkhelil
Copy link
Member

jkhelil commented Jan 11, 2025

/cherry-pick release-v0.73.x
/cherry-pick release-v0.74.x

@tekton-robot tekton-robot mentioned this pull request Jan 11, 2025
Merged
@tekton-robot
Copy link
Contributor

@jkhelil: new pull request created: #2502

In response to this:

/cherry-pick release-v0.73.x
/cherry-pick release-v0.74.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkhelil
Copy link
Member

jkhelil commented Jan 11, 2025

/cherry-pick release-v0.74.x

@tekton-robot
Copy link
Contributor

@jkhelil: new pull request created: #2507

In response to this:

/cherry-pick release-v0.74.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jan 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@jkhelil jkhelil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afrittoli @jkhelil @tekton-robot