Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TektonConfig CR's addon params to remove cluster tasks params #2439

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update TektonConfig CR's addon params to remove cluster tasks params #2439

merged 1 commit into from
Jan 6, 2025

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Dec 4, 2024 •
edited
Loading

Cluster tasks have been deprecated and removed, previous version of TektonConfig CR's addon params have the clusterTasks and communityClusterTasks params and need to remove it from the TektonConfig's addon params this removes the cluster tasks params from TektonConfig's addon params and updates it

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Update TektonConfig CR's addon params to remove cluster tasks params

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 4, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/shared/tektonconfig/upgrade/pre_upgrade.go 83.3% 48.4% -34.9

@pratap0007 pratap0007 force-pushed the refactor-ct-ins branch 2 times, most recently from 19a4395 to 92f4ddf Compare December 4, 2024 12:39
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/shared/tektonconfig/upgrade/pre_upgrade.go 83.3% 48.4% -34.9

savitaashture
savitaashture reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratap0007 did you test upgrade scenario and ensured that those params are no more

  • Also for fresh install

@pratap0007
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@jkhelil jkhelil mentioned this pull request Dec 18, 2024
Open
4 tasks
@pratap0007
Update TektonConfig CR's addon params to remove cluster tasks params
79cd3f3 
Cluster tasks have been deprecated and removed, previous version of TektonConfig CR's addon
params have the clusterTasks and communityClusterTasks params and need to remove it from the
TektonConfig's addon params this removes the cluster tasks params from TektonConfig's addon params and updates it

Signed-off-by: Shiv Verma <shverma@redhat.com>'
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 90.9% 87.5% -3.4
pkg/reconciler/shared/tektonconfig/upgrade/pre_upgrade.go 83.3% 48.4% -34.9

@pratap0007
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2025
savitaashture
savitaashture reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade works fine

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@jkhelil
Copy link
Member

jkhelil commented Jan 6, 2025

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@tekton-robot tekton-robot merged commit 7340583 into tektoncd:main Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @tekton-robot @jkhelil @savitaashture