Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pipelines to 0.47, pac to 0.19, and fix breaking changes #1481

Merged
merged 1 commit into from
May 9, 2023

Conversation

jkandasa
Copy link
Member

@jkandasa jkandasa commented May 9, 2023

Changes

bump PAC dependency to 0.19.0 (from v0.17.2)
bump pipelines dependency to 0.47.0 (from 0.45.0) and addresses breaking changes

Removed verification-mode

Actually we have to deprecate resource-verification-mode in favor of trusted-resources-verification-no-match-policy, But I removed it completely. why?

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Support added for `trusted-resources-verification-no-match-policy` under pipelines spec

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2023
@jkandasa
Copy link
Member Author

jkandasa commented May 9, 2023

/cc @vdemeester

@tekton-robot tekton-robot requested a review from vdemeester May 9, 2023 07:11
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 9, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go 75.0% 82.6% 7.6

@jkandasa jkandasa force-pushed the bump_pipelines_to_0_47 branch from 829722b to 71e062a Compare May 9, 2023 07:23
@piyush-garg
Copy link
Contributor

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go 75.0% 82.6% 7.6

Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
@jkandasa jkandasa force-pushed the bump_pipelines_to_0_47 branch from 71e062a to 636bdbb Compare May 9, 2023 07:56
@jkandasa jkandasa changed the title bump pipelines to 0.47 and update changes bump pipelines to 0.47, pac to 0.19, and fix breaking changes May 9, 2023
@jkandasa
Copy link
Member Author

jkandasa commented May 9, 2023

/test all

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go 75.0% 82.6% 7.6

@piyush-garg
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants