This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
[pipeline-to-taskrun] Add initial directory for Pipeline to TaskRun custom task 🎁 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustom task 🎁 I had tried to add the custom task and OWNERS file all at once in tektoncd#770 but @jerop pointed out it's probably a better approach to just add the OWNERS file first, which would allow getting the initial approval needed to kick off the project and from then on the project OWNERS can take care of reviews (and she documented this in tektoncd#782 !) So this commit adds just the OWNERS (more welcome if anyone else is interested!) for the pipeline to taskrun custom task, and there will be a follow-up PR with the initial controller logic. Project proposal: tektoncd/community#447
|
/lgtm |
vdemeester
approved these changes
Aug 25, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I had tried to add the custom task and OWNERS file all at once in
#770 but @jerop pointed
out it's probably a better approach to just add the OWNERS file first,
which would allow getting the initial approval needed to kick off the
project and from then on the project OWNERS can take care of reviews
(and she documented this in
#782 !)
So this commit adds just the OWNERS (more welcome if anyone else is
interested!) for the pipeline to taskrun custom task, and there will be
a follow-up PR with the initial controller logic.
Project proposal: tektoncd/community#447
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.