Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint from 1.56.2 to 1.62.2 #3848

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Bump golangci-lint from 1.56.2 to 1.62.2 #3848

merged 1 commit into from
Jan 8, 2025

Conversation

AlanGreene
Copy link
Member

Changes

Depends on #3839
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 16, 2024
@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2024
@AlanGreene AlanGreene changed the title Golangci=lint update Bump golangci-lint from 1.56.2 to 1.62.2 Dec 16, 2024
@AlanGreene AlanGreene mentioned this pull request Dec 16, 2024
Merged
@AlanGreene AlanGreene force-pushed the golangci=lint_update branch from fe6a7ac to 50cb463 Compare January 6, 2025 16:42
@AlanGreene AlanGreene marked this pull request as ready for review January 6, 2025 16:42
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 6, 2025
@AlanGreene AlanGreene force-pushed the golangci=lint_update branch from 50cb463 to 6e64fa3 Compare January 8, 2025 15:31
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2025
@AlanGreene AlanGreene force-pushed the golangci=lint_update branch from 6e64fa3 to d11db59 Compare January 8, 2025 15:38
briangleeson
briangleeson requested changes Jan 8, 2025
View reviewed changes
pkg/utils/proxy.go Outdated Show resolved Hide resolved
@AlanGreene AlanGreene force-pushed the golangci=lint_update branch from d11db59 to dd43e95 Compare January 8, 2025 16:08
briangleeson
briangleeson approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@AlanGreene
Copy link
Member Author

/retest

@AlanGreene
Copy link
Member Author

E2E failed early due to network issue installing npm dependencies, as well as timeout in one of the tests, rerunning…

@AlanGreene
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit e9811b8 into tektoncd:main Jan 8, 2025
15 checks passed
@AlanGreene AlanGreene deleted the golangci=lint_update branch January 8, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @briangleeson