Ensure existing timer is cleared before creating a new one #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen some unexpected network requests for logs in error cases, e.g. pod not ready, but have not been able to reliably reproduce them. Ensure we clear any existing timer before starting a new one to ensure we're not left with any remaining unaccounted for timers when navigating away from the logs tab. Also change existing use of `clearInterval` to `clearTimeout` for clarity. Both use the same pool of ids and so are interchangeable, but we should be consistent to avoid confusion.
|
/lgtm |
briangleeson
approved these changes
Dec 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have seen some unexpected network requests for logs in error cases,
e.g. pod not ready, but have not been able to reliably reproduce them.
Ensure we clear any existing timer before starting a new one to ensure
we're not left with any remaining unaccounted for timers when navigating
away from the logs tab.
Also change existing use of
clearIntervaltoclearTimeoutfor clarity.Both use the same pool of ids and so are interchangeable, but we should be
consistent to avoid confusion.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.