Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear All label filter incorrect layout when it overflow to the new line #2062

Closed
wingyplus opened this issue May 25, 2021 · 2 comments · Fixed by #2217
Closed

Clear All label filter incorrect layout when it overflow to the new line #2062

wingyplus opened this issue May 25, 2021 · 2 comments · Fixed by #2217
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/design Categorizes issue or PR as related to design.

Comments

@wingyplus
Copy link
Contributor

Describe the bug

I found this bug during investigate #2050. The problems found when we add labels until clear all button overflow to the next line. It will be shown like this:

Screen Shot 2564-05-25 at 21 13 59

But if we add more label, it will looks like:

Screen Shot 2564-05-25 at 21 18 15

We can see that the clear all button in the first picture is less margin than in the second picture.

Expected behaviour

Expected the clear all button should be the same layout in the second picture.

Steps to reproduce the bug

  1. Open the PipelineRuns page.
  2. Add label filter until the clear all button overflow the new line

Environment details

Found on Tekton Dashboard branch main at commit 5b1372d4cb634e84142ed3abbe60a229a379964d.

Additional Info
@wingyplus wingyplus added the kind/bug Categorizes issue or PR as related to a bug. label May 25, 2021
@wingyplus wingyplus mentioned this issue May 25, 2021
Merged
3 tasks
@AlanGreene AlanGreene added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 8, 2021
yamaken1343 added a commit to fujitsu-cdf/dashboard that referenced this issue Oct 7, 2021
@yamaken1343
fix tektoncd#2062 Add margin to prevent "Clear all btn" from moving
49b07b1
yamaken1343 added a commit to fujitsu-cdf/dashboard that referenced this issue Oct 7, 2021
@yamaken1343
Add margin to prevent "Clear all btn" from moving fix tektoncd#2062
2889050 
 I add margin to `.bx--btn` class to prevent "Clear all btn" from
 moving.
 The "filter" has  `.bx--tag` class and the "Clear All button" has
 `.bx--btn` class.
 `.bx--tag` class has margin but `.bx--btn` class has not margin. So,
 there was a gap between when there was a "filter" on the left and when
 there was no "filter".
 fix tektoncd#2062
@yamaken1343 yamaken1343 mentioned this issue Oct 7, 2021
Merged
3 tasks
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021
@AlanGreene
Copy link
Member

This is in progress, there's a PR open pending changes from review feedback.
/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021
yamaken1343 added a commit to fujitsu-cdf/dashboard that referenced this issue Oct 18, 2021
@yamaken1343
Add margin to prevent "Clear all btn" from moving fix tektoncd#2062
b57c1e7 
 I add margin to `.bx--btn` class to prevent "Clear all btn" from
 moving.
 The "filter" has  `.bx--tag` class and the "Clear All button" has
 `.bx--btn` class.
 `.bx--tag` class has margin but `.bx--btn` class has not margin. So,
 there was a gap between when there was a "filter" on the left and when
 there was no "filter".
 fix tektoncd#2062
tekton-robot pushed a commit that referenced this issue Oct 18, 2021
@yamaken1343 @tekton-robot
Add margin to prevent "Clear all btn" from moving fix #2062
530ca27 
 I add margin to `.bx--btn` class to prevent "Clear all btn" from
 moving.
 The "filter" has  `.bx--tag` class and the "Clear All button" has
 `.bx--btn` class.
 `.bx--tag` class has margin but `.bx--btn` class has not margin. So,
 there was a gap between when there was a "filter" on the left and when
 there was no "filter".
 fix #2062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/design Categorizes issue or PR as related to design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add margin to prevent "Clear all btn" from moving fix #2062 fujitsu-cdf/dashboard
3 participants
@wingyplus @AlanGreene @tekton-robot