-
Notifications
You must be signed in to change notification settings - Fork 268
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update components to support displaying new
Cancelled
status
TEP-0058 Graceful Termination deprecated the existing `PipelineRunCancelled` status. Instead, runs have the status reason `Cancelled`. The feature is still in alpha, so to test it out you can edit the `feature-flags` ConfigMap to set `enable-api-fields: alpha`, then use one of the following values when cancelling the PipelineRun: - `Cancelled` replaces the existing `PipelineRunCancelled`, interrupts any executing tasks and does not run finally tasks - `StoppedRunFinally` lets any executing tasks complete normally but does not start any new non-finally tasks, then runs finally tasks - `CancelledRunFinally` interrupts any executing non-finally tasks, then executes finally tasks In all 3 cases above, the PipelineRun status reason is `Cancelled` Update tests and storybook to include 'Cancelled' variants. The Dashboard API will still use `PipelineRunCancelled` to stop a PipelineRun. A future change once the feature has been promoted to beta will switch to the replacement `Cancelled` value. Some UI change may also be made to support the alternative behaviours, tracking this in #2094
- Loading branch information
1 parent
252b974
commit 8913256
Showing
6 changed files
with
47 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters