Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tep-0091] Mark as implemented #924

Closed
wants to merge 1 commit into from

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Jan 11, 2023

Tep-0091 is implemented as tektoncd/pipeline#5527, this commit adds implementation PRs.

Tep-0091 is implemented, this commit adds implementation PRs.
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dlorenc after the PR has been reviewed.
You can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2023
@afrittoli
Copy link
Member

Thank you @Yongxuanzhang !
In the TEP it says that resources will be verified both when applied to the cluster as well as when referenced - but I don't see an example of resources applied to the cluster in the docs https://tekton.dev/vault/pipelines-main/trusted-resources/ - it seems to refer to the remote resolution case only. Could you confirm whether the current implementation matches the TEP?

Note: API Resources (Task, Pipeline) will be verified both when applied to the cluster and when referenced in taskRun/pipelineRun. When the Run is created, referenced resources will be resolved and verified again to confirm continued verification. This will prevent the Run of a resource that was verifiable when created but is no longer verifiable, perhaps due to key revocation, a security breach, or discovery of a new vulnerability since the time of the initial verification.

Thank you!

@Yongxuanzhang
Copy link
Member Author

Thank you @Yongxuanzhang ! In the TEP it says that resources will be verified both when applied to the cluster as well as when referenced - but I don't see an example of resources applied to the cluster in the docs https://tekton.dev/vault/pipelines-main/trusted-resources/ - it seems to refer to the remote resolution case only. Could you confirm whether the current implementation matches the TEP?

Note: API Resources (Task, Pipeline) will be verified both when applied to the cluster and when referenced in taskRun/pipelineRun. When the Run is created, referenced resources will be resolved and verified again to confirm continued verification. This will prevent the Run of a resource that was verifiable when created but is no longer verifiable, perhaps due to key revocation, a security breach, or discovery of a new vulnerability since the time of the initial verification.

Thank you!

Oh thanks for reminding me of this!! Yes you're right that for now we currently support verification of reference local tasks but not when we apply these resources. I will close this for now and add it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants