[TEP-0124] Proposal to add distributed tracing for tekton tasks and pipelines #839
Conversation
|
|
|
|
||
| ## Proposal | ||
|
|
||
| Initialize a tracer provider with jaeger as the backend for each reconciler. The jaeger collector URL can be passed as an argument to the controller. |
There was a problem hiding this comment.
Passing the URL as an argument to the controller should be enough for development environments.
Eventually, it can be an enhancement out of scope for this initial TEP, we might want to implement reading configuration from a config map, so that configuration may be altered at runtime, similar to https://pkg.go.dev/knative.dev/pkg/tracing. knative/pkg relies on OpenCensus for now, and we would like to to start using OpenTelemetry right from the beginning.
|
/assign @pritidesai |
|
@afrittoli: GitHub didn't allow me to assign the following users: pxp928. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
24daf3b to
bcf6959
Compare
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
|
/test pull-community-teps-lint |
|
@afrittoli: No presubmit jobs available for tektoncd/community@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| * Propagate traces so that reconciles of a resource owned by a parent resource belong a parent span from the parent resource | ||
| * Reconcile of different resources must belong to separate traces | ||
|
|
||
| ## Proposal |
There was a problem hiding this comment.
A small architecture diagram of how jaeger integrates with tekton
There was a problem hiding this comment.
I'm not sure how to come up with an architecture diagram for this. There are only two relevant components, Tekton operator and Jaeger. Tekton operator just records the spans during reconcile process and flush them to jaeger on specific intervals.
There was a problem hiding this comment.
Sounds good. Just wanted to make sure if there was anything out of the ordinary being introduced.
There was a problem hiding this comment.
Thanks @pxp928 - a diagram would be nice indeed.
We could add a diagram in the next PR when we propose this as implementable if that's ok
|
/assign |
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
|
not sure why github removed the reviewers when I was trying to request re-review. Could someone add them back please... |
Assignees are still there, all seems fine :) |
|
/approve Looking forward to seeing where this goes! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, dibyom, pxp928, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm (Merging since all approvals have been met) |
Added a proposal to instrument tekton reconciler code for distributed tracing of tasks and pipelines.
Signed-off-by: Jayadeep KM kmjayadeep@gmail.com
/kind tep