Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark tep75&76 implemented #833

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Mark tep75&76 implemented #833

merged 1 commit into from
Sep 27, 2022

Conversation

chuangw6
Copy link
Member

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2022
@chuangw6
Copy link
Member Author

@ywluogg @Yongxuanzhang Please take a look.

@chuangw6
Copy link
Member Author

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Sep 26, 2022
@chuangw6 chuangw6 force-pushed the mark-75-76-implemented branch from f3fa04f to 8fdbae1 Compare September 26, 2022 19:39
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2022
@chuangw6 chuangw6 force-pushed the mark-75-76-implemented branch from 8fdbae1 to a146a86 Compare September 26, 2022 19:43
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@lbernick
Copy link
Member

@chuangw6 could you please add the implementation prs directly to the teps?

@ywluogg
Copy link
Contributor

ywluogg commented Sep 27, 2022 •
edited
Loading

/lgtm but I don't have permissions for lgtm

@tekton-robot
Copy link
Contributor

@ywluogg: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yongxuanzhang
Copy link
Member

Yongxuanzhang commented Sep 27, 2022 •
edited
Loading

@chuangw6 could you please add the implementation prs directly to the teps?

@chuangw6 I filtered out the PRs and can be added to the tep?
75:
tektoncd/pipeline#4786
tektoncd/pipeline#4861
tektoncd/pipeline#4867
tektoncd/pipeline#4878
tektoncd/pipeline#4883
tektoncd/pipeline#4902
tektoncd/pipeline#4904
tektoncd/pipeline#5007
tektoncd/pipeline#5083
tektoncd/pipeline#5088
tektoncd/pipeline#5090
tektoncd/pipeline#5142
tektoncd/pipeline#5144
tektoncd/pipeline#5197
tektoncd/pipeline#5222
76:
tektoncd/pipeline#4779
tektoncd/pipeline#4818
tektoncd/pipeline#4855
tektoncd/pipeline#4908
tektoncd/pipeline#4911
tektoncd/pipeline#4920
tektoncd/pipeline#4965
tektoncd/pipeline#5088
tektoncd/pipeline#5132
tektoncd/pipeline#5139

@chuangw6 chuangw6 force-pushed the mark-75-76-implemented branch from a146a86 to 3367e87 Compare September 27, 2022 19:43
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2022
@chuangw6
Copy link
Member Author

@chuangw6 could you please add the implementation prs directly to the teps?

Sounds good! Added! Thanks @lbernick !

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@chuangw6
Copy link
Member Author

Thanks @Yongxuanzhang for collecting these links. Added!

@tekton-robot tekton-robot merged commit 6d8056d into tektoncd:main Sep 27, 2022
@chuangw6
Copy link
Member Author

Thank you @ywluogg for leading this project and making it happen (mark implemented!)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@pratap0007 pratap0007 Awaiting requested review from pratap0007

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
TEP Steward Assignments
Status: UnAssigned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chuangw6 @tekton-robot @lbernick @ywluogg @Yongxuanzhang @dibyom