Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0105]: Enable graceful canceling of pipelinerun from dashboard #684

Closed

Conversation

williamlfish
Copy link

This TEP outlines a feature to the dashboard that enables a graceful canceling of a pipelinerun. Please feel free to let me know if there is additional information needed, wanted, or if there is a step in the process I am missing. Thanks!

/kind tep

…the dashboard.

    This TEP is a proposision for consiteration adding a feature to enable a graceful shutdown of a pipelinerun by updating its `spec.status` to `StoppedRunFinally` from an ui element.
@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Apr 12, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 12, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: williamlfish / name: William Fish (f36f929)

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 12, 2022
@williamlfish
Copy link
Author

/assign @vdemeester

@vdemeester
Copy link
Member

/assign @AlanGreene

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this even need a TEP as it's just about support in the dashboard the graceful termination TEP, but 👍🏼

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2022
@AlanGreene
Copy link
Member

Thanks @williamlfish. I don't think this needs a TEP and we have an issue in the Dashboard repo tracking the same: tektoncd/dashboard#2094

@williamlfish
Copy link
Author

@vdemeester thank you for looping in @AlanGreene, and to both of you for pointing out the other TEP/Issue, I'm sorry I missed it 😅 . @AlanGreene would you mind if i PR'd the dashboard with this proposed solution, or something similar?

I'll close this PR none the less and thank y'all again!

@williamlfish williamlfish deleted the tep-0105/graceful-cancel branch April 15, 2022 13:31
@AlanGreene
Copy link
Member

@williamlfish let's continue the discussion over in the Dashboard issue. You'll see some UX issues I raised originally that we'll need to resolve but I think something like your proposal works for the underlying code 👍 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: UnAssigned
Development

Successfully merging this pull request may close these issues.

4 participants