-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0105]: Enable graceful canceling of pipelinerun from dashboard #684
Conversation
…the dashboard. This TEP is a proposision for consiteration adding a feature to enable a graceful shutdown of a pipelinerun by updating its `spec.status` to `StoppedRunFinally` from an ui element.
|
/assign @vdemeester |
/assign @AlanGreene |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this even need a TEP as it's just about support in the dashboard the graceful termination TEP, but 👍🏼
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @williamlfish. I don't think this needs a TEP and we have an issue in the Dashboard repo tracking the same: tektoncd/dashboard#2094 |
@vdemeester thank you for looping in @AlanGreene, and to both of you for pointing out the other TEP/Issue, I'm sorry I missed it 😅 . @AlanGreene would you mind if i PR'd the dashboard with this proposed solution, or something similar? I'll close this PR none the less and thank y'all again! |
@williamlfish let's continue the discussion over in the Dashboard issue. You'll see some UX issues I raised originally that we'll need to resolve but I think something like your proposal works for the underlying code 👍 Thanks |
This TEP outlines a feature to the dashboard that enables a graceful canceling of a pipelinerun. Please feel free to let me know if there is additional information needed, wanted, or if there is a step in the process I am missing. Thanks!
/kind tep