TEP-0079: Tekton Catalog Support Tiers [Catalog Annotations] #613
Conversation
|
/lgtm |
|
It seems that we make the URL as the catalog UUID here while URL may change in the future or overwritten by users that may wants to freeze the repo at revision (for security/offline/internal approval or other use cases) what about having the URL in
|
|
/hold |
|
@chmouel thanks for the review and discussing further offline, updated the TEP - please take another look :) |
|
/lgtm 🥳 |
|
/assign @bobcatfish |
|
@vdemeester @vinamra28 @bobcatfish - updated the proposal, please take a look :) |
|
/approve |
In this change, we update the `tekton.dev/catalog` annotation to use a three part domain of the Catalog instead of its name and we add a Catalog url annotation as well. This makes it easier for users to know which Catalog the resource came from, especially when they have other Catalogs beyond those provided by Tekton.
| @@ -8,6 +8,7 @@ authors: | |||
| - '@jerop' | |||
| - '@vdemeester' | |||
| - '@vinamra28' | |||
| - '@chmouel' | |||
There was a problem hiding this comment.
@chmouel added you as a co-author in this TEP - please let me know if you'd prefer not to be added 😀
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, bobcatfish, vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
In this change, we update the
tekton.dev/catalogannotationto use a three part domain of the Catalog instead of its name
and we add a Catalog url annotation as well.
This makes it easier for users to know which Catalog the resource
came from, especially when they have other Catalogs beyond those
provided by Tekton.
Thank you @afrittoli for the idea in #599 (comment) 🙏🏾
/kind tep