Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triggers reference from master to main 🧙 #335

Merged
merged 1 commit into from
Mar 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roadmap.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ for Tekton Pipelines but some sneak peeks at other projects as well.
- [Results](#results)
- Tekton Projects
- [Pipeline](https://github.com/tektoncd/pipeline/blob/master/roadmap.md)
- [Triggers](https://github.com/tektoncd/triggers/blob/master/roadmap.md)
- [Triggers](https://github.com/tektoncd/triggers/blob/main/roadmap.md)
- [Catalog](https://github.com/tektoncd/catalog/blob/master/roadmap.md)
- [Dashboard](https://github.com/tektoncd/dashboard/blob/master/roadmap.md)
- [CLI](https://github.com/tektoncd/cli/blob/master/ROADMAP.md)
Expand Down
2 changes: 1 addition & 1 deletion teps/0002-custom-tasks.md
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ This requires integrators to write CRD types and controllers in order to impleme

1. As in previous iterations of this design (documented more fully in the Google Doc), require implementors to define and support two CRD types, instead of one. See the doc for full explanation of the trade-offs.

1. Allow users to instantiate arbitrary kubernetes objects by providing their entire content inline. In this approach, users would be create instances of their own custom CRDs, e.g. `CELRun`, by providing the entire body inline, much like [triggertemplates](https://github.com/tektoncd/triggers/blob/master/docs/triggertemplates.md).
1. Allow users to instantiate arbitrary kubernetes objects by providing their entire content inline. In this approach, users would be create instances of their own custom CRDs, e.g. `CELRun`, by providing the entire body inline, much like [triggertemplates](https://github.com/tektoncd/triggers/blob/main/docs/triggertemplates.md).

* pros: ultimiate flexibility

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ spec:
This is exactly the same whatever we have right now with default.
The reason to move `serviceAccountName`, `podTemplate`,
to `kubernetesResource` field is because those are part of [WithPodSpec{}](https://github.com/knative/pkg/blob/master/apis/duck/v1/podspec_types.go#L49) duck type
and which helps to support any of the pod and container field without hardcoding in [podTemplate](https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/event_listener_types.go#L62).
and which helps to support any of the pod and container field without hardcoding in [podTemplate](https://github.com/tektoncd/triggers/blob/main/pkg/apis/triggers/v1alpha1/event_listener_types.go#L62).

1.If user specify podSpec fields.
```yaml
Expand Down Expand Up @@ -337,7 +337,7 @@ With all of the above implementation we should have `Knative` dependency as vend
## Open Points

As per the proposal `kubernetesResource` will have `serviceType` and `spec` which is [WithPodSpec{}](https://github.com/knative/pkg/blob/master/apis/duck/v1/podspec_types.go#L49) duck type
so the created Deployment/Service will get the information of annotation/labels if provided as part of [EventListener](https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/event_listener_types.go#L42-L44).
so the created Deployment/Service will get the information of annotation/labels if provided as part of [EventListener](https://github.com/tektoncd/triggers/blob/main/pkg/apis/triggers/v1alpha1/event_listener_types.go#L42-L44).

But there is discussion thread [here](https://github.com/tektoncd/community/pull/186#issuecomment-685250556)
where there is a point like user should get the way to specify annotation/labels to Deployment/Service.
Expand Down
4 changes: 2 additions & 2 deletions teps/0022-trigger-immutable-input.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,15 @@ Today with overlays, users have the ability to modify incoming event payloads
either with CEL or Webhook interceptors.

For example, the following
[CEL Interceptor](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#CEL-Interceptors)
[CEL Interceptor](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#CEL-Interceptors)
can modify the incoming event payload to include a shortened SHA:

```yaml
- key: body.pull_request.head.short_sha
expression: "truncate(body.pull_request.head.sha, 7)"
```

[Webhook Interceptors](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#Webhook-Interceptors)
[Webhook Interceptors](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#Webhook-Interceptors)
can provide similar functionality with their own custom code, but they are also
required to pass back bodies in responses if they wish to preserve data.

Expand Down
12 changes: 6 additions & 6 deletions teps/0026-interceptor-plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,17 @@ Interceptors have two API surfaces:
1. Configuration: This is the part of the EventListener spec where users
configure the interceptor to use (e.g. the CEL interceptor) along with
addition configuration e.g. a CEL filter expression
([example](https://github.com/tektoncd/triggers/blob/master/examples/github/github-eventlistener-interceptor.yaml#L10))
([example](https://github.com/tektoncd/triggers/blob/main/examples/github/github-eventlistener-interceptor.yaml#L10))
2. The [runtime
interface](https://github.com/tektoncd/triggers/blob/master/pkg/interceptors/interceptors.go#L30)
interface](https://github.com/tektoncd/triggers/blob/main/pkg/interceptors/interceptors.go#L30)
that defines what information gets passed on to the interceptor code for
processing and what information the interceptor has to return (e.g a modified
event body, a yes/no on whether to continue processing etc.)

Today, interceptors come in two flavors -
[built-in](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#interceptors)
[built-in](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#interceptors)
and
[webhook](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#Webhook-Interceptors).
[webhook](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#Webhook-Interceptors).
They differ both in the end user interface as well as the runtime interface.
Built in interceptors are part of the Triggers source tree and are executed
as in process function calls. Users can provide additional configuration
Expand Down Expand Up @@ -169,7 +169,7 @@ See the [Design Details](#design-details) section below for more.

3. Backwards Compatibility

This model [diverges](#http-interface) from the existing WebHookInterceptor model. For backwards compatibility, we can keep supporting the existing [WebhookInterceptor interface](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#event-interceptor-services) for a few releases or until beta.
This model [diverges](#http-interface) from the existing WebHookInterceptor model. For backwards compatibility, we can keep supporting the existing [WebhookInterceptor interface](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#event-interceptor-services) for a few releases or until beta.

4. Secrets and RBAC concerns

Expand Down Expand Up @@ -513,7 +513,7 @@ migration strategy. This is especially useful when we modify a
behavior or add a feature that may replace and deprecate a current one.
-->

* We'll keep supporting the current [webhook interface](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#event-interceptor-services) until beta.
* We'll keep supporting the current [webhook interface](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#event-interceptor-services) until beta.

## Work Plan

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,8 @@ Namespace has sufficient permissions via Kubernetes RBAC to access the `ClusterT
As mentioned in the Summary, [this Tekton Triggers issue](https://github.com/tektoncd/triggers/issues/610) is the
source for raising this scenario here, and has a bunch of good detailed discussion.

In that issue, an approach using the [Tekton Trigger (Custom) Webhook Interceptor](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#webhook-interceptors)
could serve as the means to engage with [OPA's support for validating JWT Token (e.g OpenID Connect)](https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md#webhook-interceptors)
In that issue, an approach using the [Tekton Trigger (Custom) Webhook Interceptor](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#webhook-interceptors)
could serve as the means to engage with [OPA's support for validating JWT Token (e.g OpenID Connect)](https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#webhook-interceptors)
to validate whether the user's tokens in incoming HTTP payload can access the referenced Trigger and the Task/TaskRuns etc.
the Trigger can initiate.

Expand Down