Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0145 implemented #1099

Merged
merged 1 commit into from
Oct 30, 2023
Merged

TEP-0145 implemented #1099

merged 1 commit into from
Oct 30, 2023

Conversation

Yongxuanzhang
Copy link
Member

This commit marks TEP-0145 as implemented and adds tracking issue, implementation PRs.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
@Yongxuanzhang
TEP-0145 implemented
3fe3fc9 
This commit marks TEP-0145 as implemented and adds tracking issue,
implementation PRs.
afrittoli
afrittoli reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the TEP and for the update!
tektoncd/pipeline#7287 doesn't seem to be in scope of the original TEP, so this sounds good to me.
/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
jerop
jerop approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow dance

@tekton-robot
Copy link
Contributor

@jerop: cat image

In response to this:

/lgtm
/meow dance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 1169e04 into tektoncd:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@jerop jerop jerop approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yongxuanzhang @tekton-robot @afrittoli @jerop