Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Triggers dependency for CLI #792

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Mar 10, 2020

Changes

Now that tektoncd/triggers#469 is merged, we can get rid
of the temporary replace that used a fork of Triggers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@dibyom dibyom changed the title Update Triggers dependency for CLI WIP: Update Triggers dependency for CLI Mar 10, 2020
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2020
Now that tektoncd/triggers#469 is merged, we can get rid
of the temporary replace that used a fork of Triggers

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2020
@dibyom
Copy link
Member Author

dibyom commented Mar 10, 2020

I ran make check and it failed both on my local master as well as this branch:

=== RUN   TestGetError                                                                                                                      
    TestGetError: file_test.go:64: assertion failed: expected error "Get httpz://foo.com/task.yaml: unsupported protocol scheme \"httpz\"", 
got "Get \"httpz://foo.com/task.yaml\": unsupported protocol scheme \"httpz\""                                                              
--- FAIL: TestGetError (0.00s)                                                                                                              
FAIL                                                                                                                                        
coverage: 51.6% of statements                                                                                                               
FAIL    github.com/tektoncd/cli/pkg/file        0.364s  

@danielhelfand
Copy link
Member

I ran make check and it failed both on my local master as well as this branch:

=== RUN   TestGetError                                                                                                                      
    TestGetError: file_test.go:64: assertion failed: expected error "Get httpz://foo.com/task.yaml: unsupported protocol scheme \"httpz\"", 
got "Get \"httpz://foo.com/task.yaml\": unsupported protocol scheme \"httpz\""                                                              
--- FAIL: TestGetError (0.00s)                                                                                                              
FAIL                                                                                                                                        
coverage: 51.6% of statements                                                                                                               
FAIL    github.com/tektoncd/cli/pkg/file        0.364s  

By chance are you using go v.1.14? We experienced similar issues when the golang Tasks in the catalog we use for our release pipeline was updated.

@dibyom
Copy link
Member Author

dibyom commented Mar 10, 2020

By chance are you using go v.1.14? We experienced similar issues when the golang Tasks in the catalog we use for our release pipeline was updated.

Yes! Using go1.13 seems to have fixed it!

@dibyom dibyom changed the title WIP: Update Triggers dependency for CLI Update Triggers dependency for CLI Mar 10, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2020
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit ef61822 into tektoncd:master Mar 11, 2020
@dibyom dibyom deleted the triggers branch March 11, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants