Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps all #1487

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Bump deps all #1487

merged 1 commit into from
Jan 27, 2022

Conversation

pradeepitm12
Copy link
Contributor

@pradeepitm12 pradeepitm12 commented Jan 25, 2022

Changes

tektoncd/pipeline: * -> 0.32.0
tektoncd/triggers: * -> 0.17.1
tektoncd/hub: * -> latest
knative.dev/pkg: latest

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 25, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 25, 2022
@pradeepitm12
Copy link
Contributor Author

Seems we are getting errors after updating to triggers v0.18.0 as the test builders are removed in v0.18.0 tektoncd/triggers#1252
While testing it was observed that tkn build works fine with the update but the test fails and the mentioned pr could be the reason( we will need to update the tests)

For the release, lets go with triggers 0.17.1 and will try to update the triggers test in the upcoming pr.
cc: @vinamra28 @piyush-garg @vdemeester

@vinamra28
Copy link
Member

Seems we are getting errors after updating to triggers v0.18.0 as the test builders are removed in v0.18.0 tektoncd/triggers#1252 While testing it was observed that tkn build works fine with the update but the test fails and the mentioned pr could be the reason( we will need to update the tests)

For the release, lets go with triggers 0.17.1 and will try to update the triggers test in the upcoming pr. cc: @vinamra28 @piyush-garg @vdemeester

@pradeepitm12 I guess we aren't using any test builders in the cli but yeah let's do the release with 0.17.1 and post that we can look into it

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
go.mod Outdated
github.com/tektoncd/pipeline v0.28.0
github.com/tektoncd/plumbing v0.0.0-20210514044347-f8a9689d5bd5
github.com/tektoncd/triggers v0.16.0
github.com/tektoncd/hub/api v0.0.0-20210315114749-a667b06c02ac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradeepitm12 can you please bump the latest version of hub? This commit belongs to 5th March, 2021

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste from other pr. 😛

bump triggers to v0.17.1
bump hub/api to latest
bump knative.dev/pkg to latest
hub docs update
bump pipelines to v.32.0

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

update hub/api to latest
@vinamra28
Copy link
Member

/lgtm
/hold cancel

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 27, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@tekton-robot tekton-robot merged commit d32fe34 into tektoncd:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants