Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for full task status for backward compatibility #790

Merged
merged 1 commit into from
May 1, 2023
Merged

Re-add support for full task status for backward compatibility #790

merged 1 commit into from
May 1, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Apr 26, 2023 •
edited
Loading

Tektoncd/pipelines release v0.45 came with some breaking changes. As a result, Chains needed to be updated. Support for fully embedded task status in pipelinerun status had to be removed. This PR re-adds support for those fields to make chains compatible with older versions of Tekton pipelines (<v0.45).

This PR will close out Issue #711

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Re-add support for full task status for backward compatibility

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2023
@chitrangpatel chitrangpatel mentioned this pull request Apr 26, 2023
Closed
@chitrangpatel
Copy link
Contributor Author

cc @wlynch @lcarva

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 80.5% -2.4

@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from 5d818ac to 6f1850b Compare April 26, 2023 18:28
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 81.0% -1.9

@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from 6f1850b to 8d26241 Compare April 26, 2023 19:00
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 82.2% -0.6

@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from 8d26241 to dca71d7 Compare April 26, 2023 19:56
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 82.6% -0.2

@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from dca71d7 to c474d3e Compare April 26, 2023 20:32
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 82.6% -0.2

@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from c474d3e to c272352 Compare April 27, 2023 17:32
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 82.6% -0.2

@chitrangpatel
Copy link
Contributor Author

/assign @wlynch

wlynch
wlynch reviewed May 1, 2023
View reviewed changes
pkg/reconciler/pipelinerun/pipelinerun.go Outdated
Comment on lines 78 to 79
value := reflect.ValueOf(pr.Status)
field := value.FieldByName(fieldName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use reflection here? I think we can just revert what we did in e813ece

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I removed it.

@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from c272352 to ea8fb9d Compare May 1, 2023 14:02
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 80.5% -2.4

@chitrangpatel
Re-add support for full task specs for backward compatibility
d8ee2d0 
Tektoncd/pipelines release v0.45 came with some breaking changes. As a result, Chains needed to be updated.
Support for fully embedded task specs in pipelinerun status had to be
removed. This PR re-adds support for those fields to make chains
compatible with  older versions of Tekton pipelines (<v0.45).
@chitrangpatel chitrangpatel force-pushed the re-add-support-full-task-status branch from ea8fb9d to d8ee2d0 Compare May 1, 2023 14:15
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 82.9% 80.5% -2.4

wlynch
wlynch approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2023
@tekton-robot tekton-robot merged commit 5ca4264 into tektoncd:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@chuangw6 chuangw6 Awaiting requested review from chuangw6

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chitrangpatel @tekton-robot @wlynch