Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slsa Branding of Chains Provenance Format #687

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Slsa Branding of Chains Provenance Format #687

merged 1 commit into from
Jan 31, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jan 20, 2023 •
edited
Loading

This PR adds a new format slsa/v1 which generates the same provenance as that generated when requesting in-toto format. The unit tests and documentation have been updated to use the new branding.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

SLSA branding of the tekton generated provenance format.

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 20, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2023
@chitrangpatel
Copy link
Contributor Author

/assign @wlynch

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1
pkg/chains/storage/oci/oci.go 40.7% 21.4% -19.3

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1

@chitrangpatel
Copy link
Contributor Author

/test pull-tekton-chains-integration-tests

wlynch
wlynch requested changes Jan 24, 2023
View reviewed changes
pkg/chains/formats/slsa/README.md Outdated Show resolved Hide resolved
pkg/chains/formats/format.go Show resolved Hide resolved
docs/intoto.md Show resolved Hide resolved
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2023
@chitrangpatel chitrangpatel requested review from wlynch and removed request for lcarva and chuangw6 January 24, 2023 16:09
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1

wlynch
wlynch approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2023
@wlynch
Copy link
Member

wlynch commented Jan 27, 2023

Thanks for taking care of this!

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2023
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 27, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1

lcarva
lcarva reviewed Jan 31, 2023
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
@chitrangpatel chitrangpatel force-pushed the slsa-branding branch 2 times, most recently from 2f4551d to b7d6b15 Compare January 31, 2023 16:02
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1

@chitrangpatel
Slsa Branding of Chains Provenance Format
01caeed 
This PR adds a new format `slsa/v1` which generates the same provenance as that generated when requesting `in-toto` format. The unit tests and documentation have been updated to use the new branding.
lcarva
lcarva approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/intotoite6.go 88.9% 90.0% 1.1

@tekton-robot tekton-robot merged commit 05232aa into tektoncd:main Jan 31, 2023
@chitrangpatel chitrangpatel mentioned this pull request Feb 2, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@wlynch wlynch wlynch approved these changes

Assignees

@wlynch wlynch

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chitrangpatel @tekton-robot @wlynch @lcarva