Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structured results for PipelineRunObject #599

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Support structured results for PipelineRunObject #599

merged 1 commit into from
Nov 4, 2022

Conversation

ywluogg
Copy link
Contributor

@ywluogg ywluogg commented Oct 20, 2022 •
edited by wlynch
Loading

Changes

Support structured results for PipelineRunObject. Previously PipelineRunObject only supports string types

Fixes #595

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Support structured results for PipelineRunObject.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2022
@ywluogg ywluogg mentioned this pull request Oct 20, 2022
Closed
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 70.1% 1.0

@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 20, 2022

/assign @wlynch PTAL thanks! I think the change is relatively small

wlynch
wlynch reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add some tests? 🙏

@wlynch
Copy link
Member

wlynch commented Oct 20, 2022

@bcaton85 following up on #595 (comment)

IIRC there is places where the pipelinerun results is expected to be string.

Have a link for where this is happening? 👀

@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 20, 2022

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2022
@bcaton85
Copy link
Contributor

bcaton85 commented Oct 21, 2022 •
edited
Loading

Have a link for where this is happening? 👀

@wlynch This happens in two places, when trying to extract values from results:
https://github.com/tektoncd/chains/blob/main/pkg/artifacts/signable.go#L220
https://github.com/tektoncd/chains/blob/main/pkg/artifacts/signable.go#L267-L287

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 66.0% -3.0
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 24, 2022

Have a link for where this is happening? 👀

@wlynch This happens in two places, when trying to extract values from results: https://github.com/tektoncd/chains/blob/main/pkg/artifacts/signable.go#L220 https://github.com/tektoncd/chains/blob/main/pkg/artifacts/signable.go#L267-L287

I added a few more checks for the string values

@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 24, 2022

Looks good! Can we add some tests? 🙏

Added those tests and a few more checks for the string values

@ywluogg ywluogg requested review from wlynch and removed request for lcarva and priyawadhwa October 24, 2022 17:07
@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 24, 2022

/assign bcaton85

@bcaton85
Copy link
Contributor

I don't have access to approve or merge but LGTM

chuangw6
chuangw6 reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@chuangw6 chuangw6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ywluogg! Mostly LGTM! Just a minor comment.

pkg/artifacts/signable.go Outdated Show resolved Hide resolved
@ywluogg ywluogg requested review from chuangw6 and wlynch and removed request for wlynch and chuangw6 October 25, 2022 20:17
@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 25, 2022

/unblock

@ywluogg
Copy link
Contributor Author

ywluogg commented Oct 31, 2022

/retest

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 70.5% 1.4
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 71.2% 2.2
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 70.5% 1.4
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

wlynch
wlynch approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 71.2% 2.2
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 71.2% 2.2
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@ywluogg
Copy link
Contributor Author

ywluogg commented Nov 2, 2022

/unhold

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 71.2% 2.2
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@chuangw6
Copy link
Member

chuangw6 commented Nov 3, 2022

/retest

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.1% 71.2% 2.2
pkg/chains/objects/objects.go 21.4% 40.5% 19.0

@ywluogg
Copy link
Contributor Author

ywluogg commented Nov 4, 2022

@chuangw6 Hi Chuang, do you mind giving another LGTM again? Thanks!

@chuangw6
Copy link
Member

chuangw6 commented Nov 4, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@tekton-robot tekton-robot merged commit 516e492 into tektoncd:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuangw6 chuangw6 chuangw6 left review comments

@wlynch wlynch wlynch approved these changes

Assignees

@wlynch wlynch

@bcaton85 bcaton85

@chuangw6 chuangw6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PipelineRunObject adding supported to structured results
5 participants
@ywluogg @tekton-robot @wlynch @bcaton85 @chuangw6