Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0115] Git-based Versioning Validation #6

Merged

Conversation

QuanZhang-William
Copy link
Member

Prior to this change, the Catlin validation only supports directory-based catalog path validation (i.e. ./<catalog>/<kind>/<name>/<version>/<name>.yaml). The git-based versioning catalog is proposed in TEP-0115, with a new file path layout (i.e. ./<catalog>/<kind>/<name>/<name>.yaml).

This commit introduces a new flag versioning to the catlin validate command, indicating the versioning type of the catalog to validate. The value can be set to either directory or git. The default value is directory.

Prior to this change, the Catlin validation only supports directory-based catalog path validation (i.e. ./<catalog>/<kind>/<name>/<version>/<name>.yaml). The git-based versioning catalog is proposed in TEP-0115: https://github.com/tektoncd/community/blob/main/teps/0115-tekton-catalog-git-based-versioning.md. with a new file path layout (i.e. ./<catalog>/<kind>/<name>/<name>.yaml).

This commit introduces a new flag `versioning` to the `catlin validate` command, indicating the versioning type of the catalog to validate. The value can be set to either `directory` or `git`. The default value is `directory`.
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2022
@tekton-robot tekton-robot requested review from chmouel and sm43 October 4, 2022 16:46
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/validate/validate.go 71.8% 72.9% 1.1

Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@chmouel
Copy link
Member

chmouel commented Oct 7, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@tekton-robot tekton-robot merged commit ee16b75 into tektoncd:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants