[Fixes #481] remove add registry sidecar from docker-build tests #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @chmouel |
|
/assign @imjasonh |
imjasonh
requested changes
Aug 12, 2020
|
/hold |
655f495 to
e08b1af
Compare
|
🤦 This is why its one line... ++ python3 utils.py add_sidecar_to_yaml_file
python3: can't open file 'utils.py': [Errno 2] No such file or directory |
|
This sounds good, thanks for doign this refactoring, any chances if you can squash the commits ? (preferrably if you can separate the refactoring from the fix but that's not absolutely necessary). thanks! |
da61ed2 to
0fd422b
Compare
|
probably fetching the latest commits from upstream and rebasing the PR would help fix the CI |
imjasonh
reviewed
Aug 12, 2020
0fd422b to
1781208
Compare
1781208 to
bb1d39d
Compare
|
/test pull-tekton-catalog-integration-tests |
bb1d39d to
92ac83f
Compare
7eed158 to
3a5d60a
Compare
|
@vinamra28 @imjasonh @afrittoli @chmouel YAY! YAML! 🎉 (could you take another look) 😉 |
|
how do i remove hold 😿 |
|
/unhold |
|
/hold cancel |
3a5d60a to
aee6545
Compare
|
/test pull-tekton-catalog-integration-tests |
1 similar comment
|
/test pull-tekton-catalog-integration-tests |
imjasonh
reviewed
Aug 21, 2020
aee6545 to
123b855
Compare
123b855 to
b9600dc
Compare
The end to end test attaches a sidecar with a image registry for tasks to push into to. However, the function add_sidecar_registry sets the sidecar registry instead of appending it. Removing the function from test to remove this bug. There is a local registry being added to the test that is deployed with deployment and svc. The svc is referenced during the test instead of the sidecar. tektoncd#481
b9600dc to
f440719
Compare
|
/lgtm |
|
/lgtm |
|
/assign @chmouel |
|
/lgtm Let's see how it goes! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Overview
Summary
The end to end test attaches a sidecar with a image registry for tasks to push into to. This task is optional and is encouraged to be used for testing. However, the function add_sidecar_registry sets the sidecar registry instead of appending it. Not using the tasks will fix the test #481
TLDR;
Script sets sidecar equal to an object instead of appending it. So, Im not going to use it in my test.