[WIP] Fix sidecar not generating certs.

[popcor255]

Changes

The end to end test attaches a sidecar with a image registry for tasks to push into to. This task is optional and is encouraged to be used for testing. However, the function add_sidecar_registry sets the sidecar registry instead of appending it. Allowing the sidecar-registry to run alongside with other tasks will fix this bug. #481

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Complies with Catalog Orgainization TEP, see example. Note An issue has been filed to automate this validation

  • File path follows <kind>/<name>/<version>/name.yaml

  • Has README.md at <kind>/<name>/<version>/README.md

  • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide
for more details.

---

[imjasonh]

Thanks for this fix! Can you add some more detail to the PR description about why this is necessary, and what the behavior was before? My understanding of readinessProbe is that it would check every second (periodSeconds) until the command exited successfully. Is that not the case? What additional behavior does sleep 10 add?

[popcor255]

Thanks for this fix! Can you add some more detail to the PR description about why this is necessary, and what the behavior was before? My understanding of readinessProbe is that it would check every second (periodSeconds) until the command exited successfully. Is that not the case? What additional behavior does sleep 10 add?

Yeah, this is not a real fix. Delaying the sleep worked on my local machine. (Probably giving it time generate, which is shotty at best) Im just trying to see if it passes the test in this case as well. If so, then the readiness probe isnt working properly. If not then my dev environment is not a good indication of what is actually happening. I will update the description as well and force push the pr to a real fix, asap.

[imjasonh]

docker:19 and docker:latest currently point to the same image.

[popcor255]

docker:19 and docker:latest currently point to the same image.

I have no idea why these tests are passing now. Probably, should tag the images to prevent surprises later one. This test is super flaky. Still trying to reproduce.

[popcor255]

/test pull-tekton-catalog-integration-tests

[popcor255]

/close can't reproduce

[popcor255]

/close

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment