Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task for sending CloudEvents #331

Closed
jlpettersson opened this issue May 21, 2020 · 6 comments
Closed

Add task for sending CloudEvents #331

jlpettersson opened this issue May 21, 2020 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jlpettersson
Copy link
Member

Expected Behavior

That there is a task for sending CloudEvents.

Typical use-cases:

  • Notifying that a deployment occured.
  • Notifying that a TaskRun failed e.g. failed unit-test.
  • Notifying result from a Canary Analyze

This task would be on pair with the existing Slack an Telegram-tasks, but for CloudEvents.

Actual Behavior

I don't see this exists in Catalog

@ghost
Copy link

ghost commented May 21, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 21, 2020
@bobcatfish
Copy link
Contributor

Some context, one of the reasons this wasn't done already is that some of the CloudEvents logic in the CloudEvent PipelineResource happens in the controller vs. in the step containers like all the other PipelineResources. And one of the reasons for THAT was b/c in order to know if the currently executing Task has succeeded or failed, you had to wait until the entire thing completed (and failure would stop execution of any subsequent containers).

@jlpettersson
Copy link
Member Author

jlpettersson commented May 21, 2020

some of the CloudEvents logic in the CloudEvent PipelineResource happens in the controller vs. in the step containers like all the other PipelineResources. And one of the reasons for THAT was b/c in order to know if the currently executing Task has succeeded or failed, you had to wait until the entire thing completed (and failure would stop execution of any subsequent containers).

Right, I understand. Sounds like a mix of intern/technical events e.g. Kubernetes Event and "result reporting". Ah, right, it makes sense that a reporting-task will not execute if previous task failed, so such tasks must be places in finally:.

My intention here var purely business-oriented, e.g. letting the user know the result of a Canary-Analysis. In such case, I think this would provide value, but I agree that it would be hard to use for reporting errors. It can also be used for initiating things remote, or communicating with cloud services.

(This is just a wish for a Task - not anything I will start to work on at the moment).

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants