fix: ⚡Add teia.rocks wildcard, teztok, and connkt URLs for Interactive OBJKTs #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think it would be better to just get rid of injectCSPMetaTagIntoHTML altogether. For example hicetnunc.art should actually be treated as "unsafe" in my opinion, that domain name expired and got scooped up by someone else :/ this list can also modified by the uploader anyway. The correct place to handle this security is on the webserver itself imho. |
Zir0h
approved these changes
Dec 12, 2024
|
Agreed, imo "security" things that aren't handled by the SC should be handled by the server and not the client, "forging" objkt is really not complicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding URLs used by networked / interactive OBJKTs.