Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle substitutions as choice elements #786

Merged
merged 2 commits into from
May 14, 2023
Merged

Handle substitutions as choice elements #786

merged 2 commits into from
May 14, 2023

Conversation

tefra
Copy link
Owner

@tefra tefra commented May 14, 2023

📒 Description

Substitutions should be handled as choice elements.

Resolves #735

🔗 What I've Done

Finally after months of refactor we can now fix this easily 🚀

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (f4bcb98) 99.93% compared to head (7c0317e) 99.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   99.93%   99.96%   +0.03%     
==========================================
  Files         104      104              
  Lines        9092     9102      +10     
  Branches     2032     2035       +3     
==========================================
+ Hits         9086     9099      +13     
+ Partials        6        3       -3     
Impacted Files Coverage Δ
...ta/codegen/handlers/add_attribute_substitutions.py 100.00% <100.00%> (ø)
...data/codegen/handlers/calculate_attribute_paths.py 100.00% <100.00%> (+5.55%) ⬆️
xsdata/formats/dataclass/parsers/nodes/element.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tefra tefra force-pushed the fix-735-part-4 branch from f99f91e to 7c0317e Compare May 14, 2023 14:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tefra tefra merged commit 8e2e446 into master May 14, 2023
@tefra tefra deleted the fix-735-part-4 branch May 14, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitutiongroups cause more attributes than may be serialised
1 participant