Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Binding use fields local name #390

Merged
merged 1 commit into from
Jan 20, 2021
Merged

JSON Binding use fields local name #390

merged 1 commit into from
Jan 20, 2021

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jan 20, 2021

Closes #389

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #390 (ce5ef22) into master (2fead20) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         6271      6275    +4     
  Branches      1074      1074           
=========================================
+ Hits          6271      6275    +4     
Impacted Files Coverage Δ
xsdata/formats/dataclass/serializers/json.py 100.00% <ø> (ø)
xsdata/formats/dataclass/models/elements.py 100.00% <100.00%> (ø)
xsdata/formats/dataclass/parsers/json.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fead20...ce5ef22. Read the comment docs.

@tefra
Copy link
Owner Author

tefra commented Jan 20, 2021

I think that's one of the last big hacks in the lib, since json binding is part of the public api it should work similar to xml

@tefra tefra merged commit c860fbf into master Jan 20, 2021
@tefra tefra deleted the issue-389 branch January 20, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json binding should use the field local name
1 participant