Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read more attributes from nitrate when converting #91

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

hegerj
Copy link
Collaborator

@hegerj hegerj commented Jan 23, 2020

Added reading of status, tags, extra-pepa and extra-hardware.

Added reading of status, tags, extra-pepa and extra-hardware.
@psss
Copy link
Collaborator

psss commented Jan 28, 2020

/packit test

@psss psss self-assigned this Jan 28, 2020
@psss psss added enhancement command | import The import command labels Jan 28, 2020
@hegerj hegerj requested a review from psss January 28, 2020 12:44
psss added a commit that referenced this pull request Jan 28, 2020
Use singular for key names as defined in the specification.
Simplify test case status conversion into 'enabled'.
Catch StructuredField exception when relevancy not defined.
Remove unnecessary 'extra' keys initialization.
@psss psss merged commit 2d686b6 into master Jan 28, 2020
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Merged after a couple of adjustments in d36d46a.

@psss psss deleted the read_more_nitrate_attributes branch January 29, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command | import The import command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants