Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional attributes when converting. #89

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Optional attributes when converting. #89

merged 1 commit into from
Jan 30, 2020

Conversation

hegerj
Copy link
Collaborator

@hegerj hegerj commented Jan 22, 2020

PURPOSE file and relevancy field are no longer required when converting
tests.

@hegerj
Optional attributes when converting.
06c0f5d 
PURPOSE file and relevancy field is no longer required when converting
tests.
@hegerj hegerj requested a review from psss January 22, 2020 16:19
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-tmt-89
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@psss psss self-assigned this Jan 30, 2020
@psss psss added enhancement command | import The import command labels Jan 30, 2020
psss
psss approved these changes Jan 30, 2020
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement. Looks good. I guess the warning is not needed for missing purpose so I've removed it and merged.

psss added a commit that referenced this pull request Jan 30, 2020
@psss
Merge optional PURPOSE in test convert [#89]
abb2eec
@psss psss merged commit 06c0f5d into master Jan 30, 2020
@psss psss deleted the convert-nomandatory_attributes branch January 30, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

Assignees

@psss psss

Labels
command | import The import command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hegerj @psss