Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fmf for each tcms case when converting. #78

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

hegerj
Copy link
Collaborator

@hegerj hegerj commented Jan 10, 2020

Using tmt test convert will now create fmf file for each test case found
in tcms apart from main.fmf, which contains common attributes found in
all of the individual test cases. New files are named according to their
tcms id and contain only attributes with values that are unique to it.

Using tmt test convert will now create fmf file for each test case found
in tcms apart from main.fmf, which contains common attributes found in
all of the individual test cases. New files are named according to their
tcms id and contain only attributes with values that are unique to it.
@hegerj
Copy link
Collaborator Author

hegerj commented Jan 10, 2020

I wasn't sure where to document the changed behaviour so I would appreciate an advice.

@hegerj hegerj requested a review from psss January 10, 2020 16:21
@psss
Copy link
Collaborator

psss commented Jan 13, 2020

Tests are failing:

<Result UnboundLocalError("local variable 'testcase_data' referenced before assignment")>.exit_code

I wasn't sure where to document the changed behaviour so I would appreciate an advice.

Documentation updates should go here:

You can find the source code under docs/examples.rst. To review updated docs locally:

pip install -e .[docs]
make docs
firefox docs/_build/html/index.html

Thanks.

Also some minor changes/fixes.
@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-tmt-78
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-tmt-78
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@psss
Copy link
Collaborator

psss commented Jan 14, 2020

Looks good now. Thanks. I see a couple of minor issues. We can improve them later.

@psss psss self-assigned this Jan 14, 2020
@psss psss merged commit f5f5862 into master Jan 14, 2020
@psss psss deleted the jheger-create_fmf_per_testcase branch January 14, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants