Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the report step upon failures as well #3466

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Run the report step upon failures as well #3466

merged 2 commits into from
Jan 14, 2025

Conversation

psss
Copy link
Collaborator

@psss psss commented Jan 13, 2025 •
edited
Loading

In order to report at least partial test results, let's execute the report step also when the test run is interrupted in the middle of the test execution (for example when the guest becomes unresponsive).

Fix #3401.

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • include a release note

@psss psss added priority | must high priority, must be included in the next release step | report Stuff related to the report step ci | full test Pull request is ready for the full test execution labels Jan 13, 2025
@psss
Run the report step upon failures as well
21deec1 
In order to report at least partial test results, let's execute
the `report` step also when the test run is interrupted in the
middle of the test execution (for example when the guest becomes
unresponsive).
@psss psss added this to the 1.41 milestone Jan 13, 2025
KwisatzHaderach
KwisatzHaderach approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@KwisatzHaderach KwisatzHaderach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, this might actually want a release note though.

happz
happz approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@happz happz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly harmless. What could go wrong.

@psss
Copy link
Collaborator Author

psss commented Jan 14, 2025

Code looks good, this might actually want a release note though.

Good, point added in c6920cc.

@psss psss merged commit d9d5921 into main Jan 14, 2025
20 checks passed
@psss psss deleted the report-on-error branch January 14, 2025 10:41
@psss psss self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release step | report Stuff related to the report step
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.

The report step should be executed upon errors
3 participants
@psss @happz @KwisatzHaderach