Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tmt test import error when restraint metadata attributes are empty #3451

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix tmt test import error when restraint metadata attributes are empty #3451

merged 1 commit into from
Jan 9, 2025
+28 −2

Conversation

therazix
Copy link
Collaborator

@therazix therazix commented Jan 7, 2025

This PR fixes the "list index out of range" error that occurs when the dependencies or softDependencies attribute in restraint metadata is empty.

Resolves #3186

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@therazix therazix added command | import The import command code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Jan 7, 2025
@therazix therazix added this to the 1.41 milestone Jan 7, 2025
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 9, 2025
@psss psss force-pushed the fvagner-empty-restraint-attrs branch from 34b6b6c to a018d38 Compare January 9, 2025 12:49
psss
psss approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@happz happz added the ci | full test Pull request is ready for the full test execution label Jan 9, 2025
@happz
Copy link
Collaborator

happz commented Jan 9, 2025

/packit build

@psss psss merged commit 9cc6692 into main Jan 9, 2025
20 checks passed
@psss psss deleted the fvagner-empty-restraint-attrs branch January 9, 2025 15:19
@psss psss self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@seberm seberm seberm approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. command | import The import command status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.

tmt test import got "list index out of range" when restraint metadata includes empty attributes
4 participants
@therazix @happz @seberm @psss