Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace WikiChip link with CPU World in hardware specification #3441

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Replace WikiChip link with CPU World in hardware specification #3441

merged 2 commits into from
Jan 6, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 2, 2025

It seems that WikiChip site is dead, which ruins our documentation checks.

Pull Request Checklist

  • implement the feature

@happz
Replace WikiChip link with CPU World in hardware specification
b85437b 
It seems that WikiChip site is dead, which ruins our documentation
checks.
@happz happz added documentation Improvements or additions to documentation status | blocking other work An important pull request, blocking other pull requests or issues labels Jan 2, 2025
@happz happz added this to the 1.41 milestone Jan 2, 2025
psss
psss approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks for fixing this. I just removed the unnecessary suffix in 6b6ff48.

@psss psss self-assigned this Jan 6, 2025
@psss psss merged commit 7501a7b into main Jan 6, 2025
12 of 20 checks passed
@psss psss deleted the docs-wikichip-seems-to-be-tired-a-bit branch January 6, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
documentation Improvements or additions to documentation status | blocking other work An important pull request, blocking other pull requests or issues
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.
2 participants
@happz @psss