-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark AVC check as expected when running AVC check test on localhost #3328
Merged
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e66813
to
a7d64af
Compare
psss
reviewed
Oct 31, 2024
This is an unexpected consequence of checks being interpreted in 1.38: tmt in TF runs a test, test runs another tmt which triggers an AVC denial, on purpose, but thanks to all this happening on localhost, TF tmt can notice the AVC denial, and report it as a failed check. Adding `xfail` to prevent this.
e61ff66
to
7a004ae
Compare
psss
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
seberm
approved these changes
Oct 31, 2024
martinhoyer
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checked the failures, all are related to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci | full test
Pull request is ready for the full test execution
code | no functional change
"No Functional Change" intended. Patch should not change tmt's behavior in any way.
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
test coverage
Improvements or additions to test coverage of tmt itself
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unexpected consequence of checks being interpreted in 1.38:
tmt in TF runs a test, test runs another tmt which triggers an AVC
denial, on purpose, but thanks to all this happening on localhost, TF
tmt can notice the AVC denial, and report it as a failed check. Adding
xfail
to prevent this.Pull Request Checklist