Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark AVC check as expected when running AVC check test on localhost #3328

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Mark AVC check as expected when running AVC check test on localhost #3328

merged 3 commits into from
Oct 31, 2024
+18 −0

Conversation

happz
Copy link
Collaborator

@happz happz commented Oct 30, 2024 •
edited
Loading

This is an unexpected consequence of checks being interpreted in 1.38:
tmt in TF runs a test, test runs another tmt which triggers an AVC
denial, on purpose, but thanks to all this happening on localhost, TF
tmt can notice the AVC denial, and report it as a failed check. Adding
xfail to prevent this.

Pull Request Checklist

  • implement the feature

@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 30, 2024
@happz happz force-pushed the avc-check-now-fails-in-tf branch 2 times, most recently from 7e66813 to a7d64af Compare October 30, 2024 13:51
@happz happz changed the title f Mark AVC check as expected when running AVC check test on localhost Oct 30, 2024
@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself labels Oct 30, 2024
@happz happz marked this pull request as ready for review October 30, 2024 13:52
@happz happz added this to the 1.39 milestone Oct 30, 2024
happz added 3 commits October 31, 2024 13:38
@happz
Mark AVC check as expected when running AVC check test on localhost
8ac7a37 
This is an unexpected consequence of checks being interpreted in 1.38:
tmt in TF runs a test, test runs another tmt which triggers an AVC
denial, on purpose, but thanks to all this happening on localhost, TF
tmt can notice the AVC denial, and report it as a failed check. Adding
`xfail` to prevent this.
@happz
squash: bump one missing version
f003a6c
@happz
squash: drop unexpected change
7a004ae
@happz happz force-pushed the avc-check-now-fails-in-tf branch from e61ff66 to 7a004ae Compare October 31, 2024 12:50
psss
psss approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Oct 31, 2024
martinhoyer
martinhoyer approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psss
Copy link
Collaborator

psss commented Oct 31, 2024

Checked the failures, all are related to the fedora-41 changes, merging.

@psss psss merged commit add8fcf into main Oct 31, 2024
15 of 22 checks passed
@psss psss deleted the avc-check-now-fails-in-tf branch October 31, 2024 20:16
@psss psss self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberm seberm seberm approved these changes

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @psss @seberm @martinhoyer