Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --keep for tmt clean #3183

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Implement --keep for tmt clean #3183

merged 1 commit into from
Dec 5, 2024

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Sep 3, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily
Copy link
Collaborator Author

Depends on #3182

@skycastlelily skycastlelily force-pushed the keep-guests branch 2 times, most recently from 837a8d9 to 50cf34d Compare November 27, 2024 07:21
Base automatically changed from keep-guests to main November 28, 2024 07:48
skycastlelily added a commit that referenced this pull request Nov 28, 2024
@skycastlelily
Implement the --keep option for tmt clean (#3183)
72e7b61
@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Nov 28, 2024
@skycastlelily skycastlelily added this to the 1.40 milestone Nov 28, 2024
skycastlelily added a commit that referenced this pull request Nov 28, 2024
@skycastlelily
Implement the --keep option for tmt clean (#3183)
fff4298
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Dec 5, 2024
@happz
Copy link
Collaborator

happz commented Dec 5, 2024

Unrelated rawhide failures, merging.

@happz happz merged commit 2df13a9 into main Dec 5, 2024
19 of 20 checks passed
@happz happz deleted the keep-clean branch December 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
3 participants
@skycastlelily @happz @KwisatzHaderach