Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide internal fields of provision plugins #3181

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Hide internal fields of provision plugins #3181

merged 1 commit into from
Sep 6, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 2, 2024

Pull Request Checklist

  • implement the feature

@happz happz added code | style Code style changes not affecting functionality code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 2, 2024
@happz happz added this to the 1.37 milestone Sep 2, 2024
thrix
thrix approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix added the ci | full test Pull request is ready for the full test execution label Sep 5, 2024
@thrix
Copy link
Collaborator

thrix commented Sep 5, 2024

/packit test

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 6, 2024
@happz happz force-pushed the provision-hide-internal-fields branch from f97cdd9 to 6d04a30 Compare September 6, 2024 08:22
@happz happz merged commit c2ef56a into main Sep 6, 2024
22 checks passed
@happz happz deleted the provision-hide-internal-fields branch September 6, 2024 12:04
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Hide internal fields of provision plugins (teemtee#3181)
bbaaf91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@therazix therazix therazix approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual

@frantisekz frantisekz Awaiting requested review from frantisekz frantisekz is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | style Code style changes not affecting functionality code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @thrix @therazix