Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SSH master sockets under workdir #3165

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

happz
Copy link
Collaborator

@happz happz commented Aug 26, 2024

Instead of a shared, global directory under /run, moving SSH sockets into a workdir. It's run-specific, there is no chance of collision between multiple tmt invocations.

Fixes #3164.

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working step | provision Stuff related to the provision step labels Aug 26, 2024
@happz happz added this to the 1.36 milestone Aug 26, 2024
@happz happz force-pushed the ssh-sockets-moved-into-workdir branch from f367e70 to 435617e Compare August 27, 2024 11:17
@happz happz added the ci | full test Pull request is ready for the full test execution label Aug 27, 2024
@happz happz force-pushed the ssh-sockets-moved-into-workdir branch from 435617e to dc0e169 Compare August 27, 2024 11:29
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 29, 2024
happz added 2 commits August 30, 2024 12:39
Instead of a shared, global directory under `/run`, moving SSH sockets
into a workdir. It's run-specific, there is no chance of collision
between multiple tmt invocations.

Fixes #3164.
@happz happz force-pushed the ssh-sockets-moved-into-workdir branch from dc0e169 to c816f49 Compare August 30, 2024 10:39
@happz happz merged commit f054be9 into main Aug 30, 2024
22 checks passed
@happz happz deleted the ssh-sockets-moved-into-workdir branch August 30, 2024 14:19
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Instead of a shared, global directory under `/run`, moving SSH sockets
into a workdir. It's run-specific, there is no chance of collision
between multiple tmt invocations.

Fixes teemtee#3164.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | provision Stuff related to the provision step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't use several instances of tmt run in parallel
4 participants