Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (custom) result file validation, schema-based #3153

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Add (custom) result file validation, schema-based #3153

merged 4 commits into from
Aug 27, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Aug 16, 2024

And fix some of the issues reported by this simple addition:

  • results schema was defining subresults as a single result,
  • some broken references,
  • skip was missing from the list of allowed outcomes.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • include a release note

@happz happz added step | execute Stuff related to the execute step area | results Related to how tmt stores and shares results labels Aug 16, 2024
@happz happz added this to the 1.36 milestone Aug 16, 2024
happz
happz commented Aug 16, 2024
View reviewed changes
tmt/utils/__init__.py Outdated Show resolved Hide resolved
@happz happz mentioned this pull request Aug 19, 2024
Merged
14 tasks
thrix
thrix reviewed Aug 20, 2024
View reviewed changes
tmt/schemas/results.yaml Outdated Show resolved Hide resolved
thrix
thrix requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

@happz happz force-pushed the result-schema-wrong-subresults branch from 964664c to 4ddbfc7 Compare August 20, 2024 12:39
@thrix thrix requested review from thrix and LecrisUT August 22, 2024 11:33
thrix
thrix approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 22, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Aug 27, 2024
happz added 4 commits August 27, 2024 09:47
@happz
Add (custom) result file validation, schema-based
6580c98 
And fix some of the issues reported by this simple addition:

* results schema was defining subresults as a single result,
* some broken references,
* `skip` was missing from the list of allowed outcomes.
@happz
squash: Update tmt/utils/__init__.py
9f37ef0
@happz
squash: fix definition references
f1f18df
@happz
squash: fix docstring
4707545
@happz happz force-pushed the result-schema-wrong-subresults branch from ac31e8e to 4707545 Compare August 27, 2024 07:47
@happz
Copy link
Collaborator Author

happz commented Aug 27, 2024

Unrelated failure, merging.

@happz happz merged commit 9c9b407 into main Aug 27, 2024
20 of 22 checks passed
@happz happz deleted the result-schema-wrong-subresults branch August 27, 2024 09:28
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Add (custom) result file validation, schema-based (teemtee#3153)
13aef22 
And fix some of the issues reported by this simple addition:

* results schema was defining subresults as a single result,
* some broken references,
* `skip` was missing from the list of allowed outcomes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberm seberm seberm approved these changes

@thrix thrix thrix approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
area | results Related to how tmt stores and shares results ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | execute Stuff related to the execute step
Projects
None yet
Milestone
1.36
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @seberm @thrix @LecrisUT