Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HW requirement implementation links to match reality #3066

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Update HW requirement implementation links to match reality #3066

merged 2 commits into from
Jul 18, 2024

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Jul 2, 2024 •
edited by psss
Loading

Pull Request Checklist

  • update the specification

@happz
Copy link
Collaborator

happz commented Jul 2, 2024

@skycastlelily please, consider extending the subject. "Update spec files" can mean anything, and provides no pointer to what changed and why. Something like "Update HW requirement implementation links to match reality" would be way more helpful.

@happz happz added documentation Improvements or additions to documentation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. area | hardware Implementation of hardware requirements labels Jul 2, 2024
@happz happz added this to the 1.35 milestone Jul 2, 2024
@skycastlelily
Copy link
Collaborator Author

skycastlelily commented Jul 2, 2024 via email

therazix
therazix requested changes Jul 16, 2024
View reviewed changes
spec/hardware/disk.fmf Outdated Show resolved Hide resolved
@thrix thrix changed the title Update spec files Update HW requirement implementation links to match reality Jul 16, 2024
@thrix
Copy link
Collaborator

thrix commented Jul 16, 2024

Updated^^

@skycastlelily thx, I updated also MR description :) unfortunately it is not done automatically :(

@skycastlelily
Copy link
Collaborator Author

Updated^^

@skycastlelily thx, I updated also MR description :) unfortunately it is not done automatically :(

Thanks:)

@thrix thrix requested a review from therazix July 18, 2024 11:32
thrix
thrix approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 18, 2024
@psss
Copy link
Collaborator

psss commented Jul 18, 2024

Specification update --> full test not needed --> merging.

@psss psss merged commit df10687 into main Jul 18, 2024
11 of 19 checks passed
@psss psss deleted the update-spec branch July 18, 2024 13:07
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@skycastlelily @The-Mule
Update HW requirement implementation links to match reality (teemtee#…
4f18e8c 
…3066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
area | hardware Implementation of hardware requirements code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
5 participants
@skycastlelily @happz @thrix @psss @therazix