-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish docs Makefile #3045
Polish docs Makefile #3045
Conversation
ed070cd
to
b652e86
Compare
Btw, doesn't the makefile not account for the fmf file dependencies right now? There are even more subtle dependencies on git branch and such when we were looking at linkcheck (is there really no sphinx |
Nope, not yet, although I could add collection of spec/story fmf files & add them as dependencies. That shouldn't be hard, and it's quite a visible dependency.
True, but I chose to ignore those :) If we start adding these, we should probably fix also the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@happz, could you please rebase on the latest |
b652e86
to
05394ea
Compare
* add comments to variables, targets and their groups, * reduce duplication with custom functions (mostly around plugin docs), * slightly increased padding for target name when rendering help, to keep things aligned even for the longest target.
05394ea
to
a08a4be
Compare
Pull Request Checklist