Create run.yaml for tmt try

[skycastlelily]

Pull Request Checklist

Resolves #2888

• implement the feature
• extend the test coverage

[skycastlelily]

fix this issue:#2888 ^^

[lukaszachy]

/packit test

[thrix]

LGTM

[psss]

Thanks for the fix! Overall looks good. I gave it a quick try and ran into regression:

cd
tmt try

Before I was able to enter directory without tmt metadata and quickly start experimenting but now I get the following:

No metadata found in the '.' directory. Use 'tmt init' to get started.

Could you please look into it? Also, what about extending the related test coverage a bit? We could extend the keep test case here:

tmt/tests/try/basic/test.sh

Lines 48 to 51 in cd73dd7

	rlPhaseStartTest "Keep"
	rlRun -s "./keep.exp" 0 "Quit the session"
	rlAssertGrep "Run .* kept unfinished. See you soon!" $rlRun_LOG
	rlPhaseEnd

It would be also good to add a test case for the above-mentioned scenario which was affected by the change.

[happz]

Deferring to 1.35 to get more time to resolve the (minor yet pesky) issues reported in #2889 (review)

[skycastlelily]

We could extend the keep test case here:

tmt/tests/try/basic/test.sh

Lines 48 to 51 in cd73dd7

	rlPhaseStartTest "Keep"
	rlRun -s "./keep.exp" 0 "Quit the session"
	rlAssertGrep "Run .* kept unfinished. See you soon!" $rlRun_LOG
	rlPhaseEnd

It would be also good to add a test case for the above-mentioned scenario which was affected by the change.

Looks like keep test case also covers that scenario

(dev) lnie@fedora:~/tmt$ cat ./tests/try/basic/data/keep.exp
#!/usr/bin/expect -f
# Select a plan and keep the run

spawn tmt try -p plan
expect "What do we do next?"
send -- "k\r"
expect eof

I can reproduce that issue with my original MR but can't produce it after updated the code

[lnie@ceph-04 ~]$ tmt try -p plan
/var/tmp/tmt/run-009
No metadata found in the '.' directory. Use 'tmt init' to get started.

[lnie@ceph-04 ~]$ tmt try -p plan
/var/tmp/tmt/run-010
No plan matching 'plan' found.

Please let me know if I miss anything,thanks:)

[therazix]

@skycastlelily It looks like commit 421fea8 doesn't belong to this pull request and shouldn't be here.

[skycastlelily]

Not sure how it happened😅 Should be good now:)

…

On Tue, Jul 9, 2024 at 3:19 AM Filip Vágner ***@***.***> wrote: @skycastlelily <https://github.com/skycastlelily> It looks like commit 421fea8 <421fea8> doesn't belong to this pull request and shouldn't be here. — Reply to this email directly, view it on GitHub <#2889 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23CRES2IKAH4YE2G6M3ZLLQ5JAVCNFSM6AAAAABGYPEWPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHE4TIMRRG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[happz]

@skycastlelily would you be able to add a test as suggested by Petr in #2889 (review)? Even a trivial one would be better than nothing.

Nevermind, I was shown #2889 (comment)

[thrix]

@skycastlelily would you be able to add a test as suggested by Petr in #2889 (review)? Even a trivial one would be better than nothing.

I believe she covered this in this reply #2889 (comment)

[happz]

/packit test

[happz]

Unrelated failures, merging.