-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create run.yaml
for tmt try
#2889
Conversation
fix this issue:#2888 ^^ |
/packit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Overall looks good. I gave it a quick try and ran into regression:
cd
tmt try
Before I was able to enter directory without tmt
metadata and quickly start experimenting but now I get the following:
No metadata found in the '.' directory. Use 'tmt init' to get started.
Could you please look into it? Also, what about extending the related test coverage a bit? We could extend the keep
test case here:
Lines 48 to 51 in cd73dd7
rlPhaseStartTest "Keep" | |
rlRun -s "./keep.exp" 0 "Quit the session" | |
rlAssertGrep "Run .* kept unfinished. See you soon!" $rlRun_LOG | |
rlPhaseEnd |
It would be also good to add a test case for the above-mentioned scenario which was affected by the change.
Deferring to 1.35 to get more time to resolve the (minor yet pesky) issues reported in #2889 (review) |
Looks like keep test case also covers that scenario
I can reproduce that issue with my original MR but can't produce it after updated the code
Please let me know if I miss anything,thanks:) |
@skycastlelily It looks like commit 421fea8 doesn't belong to this pull request and shouldn't be here. |
Not sure how it happened😅 Should be good now:)
…On Tue, Jul 9, 2024 at 3:19 AM Filip Vágner ***@***.***> wrote:
@skycastlelily <https://github.com/skycastlelily> It looks like commit
421fea8
<421fea8>
doesn't belong to this pull request and shouldn't be here.
—
Reply to this email directly, view it on GitHub
<#2889 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23CRES2IKAH4YE2G6M3ZLLQ5JAVCNFSM6AAAAABGYPEWPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHE4TIMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Nevermind, I was shown #2889 (comment) |
I believe she covered this in this reply #2889 (comment) |
/packit test |
Unrelated failures, merging. |
Pull Request Checklist
Resolves #2888