Use testinfo.desc #160
Closed
Use testinfo.desc #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of Makefile use testinfo.desc which has variables resolved.
9de08cb to
ba74833
Compare
psss
reviewed
Mar 11, 2020
tmt.spec
Outdated
| @@ -79,7 +79,7 @@ Summary: Extra dependencies for the Test Management Tool | |||
| Requires: tmt >= %{version} | |||
| Requires: tmt-container >= %{version} | |||
| Requires: tmt-testcloud >= %{version} | |||
| Requires: vagrant python3-nitrate | |||
| Requires: vagrant python3-nitrate Make | |||
There was a problem hiding this comment.
I guess that should be make?
# dnf install -y Make
Last metadata expiration check: 1:36:28 ago on Wed Mar 11 09:24:36 2020.
No match for argument: Make
* Maybe you meant: make
Error: Unable to find a match: Make
There was a problem hiding this comment.
yes, mistake during rebase
fixed e2e3953
Before it only worked if you converted tests in cwd.
|
Fixes #131 |
|
/packit test |
psss
added a commit
that referenced
this pull request
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of Makefile use testinfo.desc which has variables resolved.