-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment support to the discover step #145
Conversation
Any test with environment variable set still fails because of problem mentioned in #99. |
LGTM. |
/test |
Combine L1 and L2 environment in Test.export(). Include a simple test with an environment variable. Extend utils.format() to support dictionaries as well.
37d8279
to
c12e615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@psss for my information, what's blocking that (from tmt side)? |
/packit test |
Would be good to improve the output/logging/results presentation. But I think the main point is just the priority. The cruncher is somewhat stable and changing that would require extra time and effort. We just need to prioritize this well. |
/packit test |
All tests passed, just the results are not updated here. Let's give it one more attempt. |
/packit build |
/packit test |
All tests passed. There is a problem with Packit results reporting. Merging. |
Combine L1 and L2 environment in Test.export().
Include a simple test with an environment variable.
Extend utils.format() to support dictionaries as well.