Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman provisioner #106

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Add podman provisioner #106

merged 3 commits into from
Feb 13, 2020

Conversation

thrix
Copy link
Collaborator

@thrix thrix commented Feb 12, 2020

This patch adds podman provisioner which for now also provides 'how: container'.

Along comes a test for it:

tmt run plan --name container

Also add a new subpackage tmt-container to install this provisioner
dependencies.

TODO:

  • discuss and fix container cleanup, now all containers stay up and running ....
  • add test for shell executor

Signed-off-by: Miroslav Vadkerti mvadkert@redhat.com

@packit-as-a-service
Copy link

There was an error while creating SRPM. You can re-trigger build by adding a comment (/packit copr-build) into this pull request.

Output:

Preparing of the upstream to the SRPM build failed: Failed to parse SPEC file: error: Package has no %description: tmt-container

This patch adds podman provisioner which for now also provides 'how: container'.

Along comes a test for it:

    tmt run plan --name container

Also add a new subpackage tmt-container to install this provisioner
dependencies.

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix thrix force-pushed the rfe-podman-provisioner branch from 2d060ec to 3f51278 Compare February 13, 2020 08:37
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-tmt-106
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@thrix
Copy link
Collaborator Author

thrix commented Feb 13, 2020

@psss any idea why we do not build tmt-container, is there anything else missing from the spec??

t184256 and others added 2 commits February 13, 2020 15:43
Include license to build the tmt-container package.
Use --container-pull option to prevent future collisions.
Fix a couple of typos, wrap long lines, style adjustments.
@psss psss force-pushed the rfe-podman-provisioner branch from fb7cdb0 to 54e6f5c Compare February 13, 2020 15:05
@psss
Copy link
Collaborator

psss commented Feb 13, 2020

@psss any idea why we do not build tmt-container, is there anything else missing from the spec??

Hm, probably no file, no package. I've included at least license as for the tmt-all. Now it builts correctly.

@psss psss self-assigned this Feb 13, 2020
@psss psss added enhancement step | provision Stuff related to the provision step labels Feb 13, 2020
psss added a commit that referenced this pull request Feb 13, 2020
@psss psss merged commit 54e6f5c into master Feb 13, 2020
@psss psss deleted the rfe-podman-provisioner branch February 13, 2020 15:38
@psss
Copy link
Collaborator

psss commented Feb 13, 2020

Thanks much for implementing this, @thrix! Merged to master :-)

@pvalena
Copy link
Collaborator

pvalena commented Feb 13, 2020

Hm, probably no file, no package. I've included at least license as for the tmt-all. Now it builts correctly.

Yes, that's correct. Why doesn't it have any container-specific files? (Why do we actually need it?)

@pvalena
Copy link
Collaborator

pvalena commented Feb 13, 2020

@psss Also please vary of mixing various versions of your sub-packages (by default the subpackage does not depend on specific version of a "main" package it's built with).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step | provision Stuff related to the provision step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants